Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2931833004: Always set the navigation pending item for page reload. (Closed)
Patch Set: only reload cases Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index a86f1374b8835774493a7889dab9850cfed5bd95..7e4dc8e832835a0678cdd37b127a629a58f7559f 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -967,13 +967,7 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
web::NavigationItem* navigationItem =
[self navigationManager]->GetPendingItem();
-
- // TODO(crbug.com/676129): the pending item is not correctly set when the
- // page is reloading, use the last committed item if pending item is null.
- // Remove this once tracking bug is fixed.
- if (!navigationItem)
- navigationItem = [self navigationManager]->GetLastCommittedItem();
-
+ DCHECK(navigationItem);
[[OmniboxGeolocationController sharedInstance]
addLocationToNavigationItem:navigationItem
browserState:_browserState];

Powered by Google App Engine
This is Rietveld 408576698