Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2931723002: [MD settings] adjust button layout (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[MD settings] adjust button layout This CL gives proper spacing of paper-buttons in settings boxes. There are several cases to consider: a button at the start of a row; a button at the end of the row; multiple buttons in a row; buttons before or after a separator. BUG=725172, 726262, 724944 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2902363002 Cr-Original-Commit-Position: refs/heads/master@{#476067} Review-Url: https://codereview.chromium.org/2931723002 . Cr-Commit-Position: refs/branch-heads/3112@{#235} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/c366c9166c518e396d66db4edf2a7f0dba12e7f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M chrome/browser/resources/settings/controls/controlled_button.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 2 chunks +24 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/shared_style_css.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/shared_vars_css.html View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
dschuyler
3 years, 6 months ago (2017-06-07 21:03:41 UTC) #1
Description was changed from

==========
[MD settings] adjust button layout

This CL gives proper spacing of paper-buttons in settings boxes. There are
several cases to consider: a button at the start of a row; a button at the end
of the row; multiple buttons in a row; buttons before or after a separator.

BUG=725172, 726262, 724944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2902363002
Cr-Commit-Position: refs/heads/master@{#476067}
(cherry picked from commit e959cddaeca101036a8edf445a5d57c629632afc)
==========

to

==========
[MD settings] adjust button layout

This CL gives proper spacing of paper-buttons in settings boxes. There are
several cases to consider: a button at the start of a row; a button at the end
of the row; multiple buttons in a row; buttons before or after a separator.

BUG=725172, 726262, 724944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2902363002
Cr-Original-Commit-Position: refs/heads/master@{#476067}
Review-Url: https://codereview.chromium.org/2931723002 .
Cr-Commit-Position: refs/branch-heads/3112@{#235}
Cr-Branched-From:
b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed:
https://chromium.googlesource.com/chromium/src/+/c366c9166c518e396d66db4edf2a...
==========

Powered by Google App Engine
This is Rietveld 408576698