Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2931643002: chromeos: Introduce ash::SystemTrayTestApi (Closed)

Created:
3 years, 6 months ago by James Cook
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, je_julie, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Introduce ash::SystemTrayTestApi This eliminates a bunch of GetFooForTesting() methods on ash::SystemTray. BUG=none TEST=ash_unittests, browser_tests Review-Url: https://codereview.chromium.org/2931643002 Cr-Commit-Position: refs/heads/master@{#477968} Committed: https://chromium.googlesource.com/chromium/src/+/a1b2a09621c170787117dc43c6823300c1d06ec6

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -82 lines) Patch
M ash/system/enterprise/tray_enterprise_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M ash/system/network/tray_network_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/system/session/tray_session_length_limit_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ash/system/supervised/tray_supervised_user_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/tray/system_tray.h View 1 1 chunk +1 line, -13 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 1 chunk +0 lines, -29 lines 0 comments Download
A ash/system/tray/system_tray_test_api.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M ash/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc View 3 chunks +10 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/shutdown_policy_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_client_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 29 (18 generated)
James Cook
xiyuan, please take a look.
3 years, 6 months ago (2017-06-07 16:15:13 UTC) #4
xiyuan
lgtm % green bots :) https://codereview.chromium.org/2931643002/diff/1/ash/system/tray/system_tray_test_api.h File ash/system/tray/system_tray_test_api.h (right): https://codereview.chromium.org/2931643002/diff/1/ash/system/tray/system_tray_test_api.h#newcode30 ash/system/tray/system_tray_test_api.h:30: SystemTray* tray_; nit: SystemTray* ...
3 years, 6 months ago (2017-06-07 16:29:09 UTC) #7
James Cook
Thanks for the quick review! https://codereview.chromium.org/2931643002/diff/1/ash/system/tray/system_tray_test_api.h File ash/system/tray/system_tray_test_api.h (right): https://codereview.chromium.org/2931643002/diff/1/ash/system/tray/system_tray_test_api.h#newcode30 ash/system/tray/system_tray_test_api.h:30: SystemTray* tray_; On 2017/06/07 ...
3 years, 6 months ago (2017-06-07 16:35:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931643002/40001
3 years, 6 months ago (2017-06-07 16:38:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/462959)
3 years, 6 months ago (2017-06-07 17:57:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931643002/40001
3 years, 6 months ago (2017-06-07 20:44:51 UTC) #18
commit-bot: I haz the power
CQ cannot get SignCLA result. Please try later.
3 years, 6 months ago (2017-06-07 20:45:35 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931643002/40001
3 years, 6 months ago (2017-06-07 20:53:49 UTC) #22
commit-bot: I haz the power
CQ cannot get SignCLA result. Please try later.
3 years, 6 months ago (2017-06-07 20:55:16 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931643002/40001
3 years, 6 months ago (2017-06-08 13:58:36 UTC) #26
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 15:08:17 UTC) #29
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a1b2a09621c170787117dc43c682...

Powered by Google App Engine
This is Rietveld 408576698