Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Issue 2931623002: Use independent URLLoader in browser-side code (Closed)

Created:
3 years, 6 months ago by kinuko
Modified:
3 years, 6 months ago
Reviewers:
jam, yzshen1, yhirano
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, blink-worker-reviews_chromium.org, rdsmith+watch_chromium.org, loading-reviews_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use independent URLLoader in browser-side code BUG=729503 Review-Url: https://codereview.chromium.org/2931623002 Cr-Commit-Position: refs/heads/master@{#477890} Committed: https://chromium.googlesource.com/chromium/src/+/acde73a7fa15b3877a342ddd8c5d71e97f070aa8

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -24 lines) Patch
M content/browser/loader/navigation_url_loader_network_service.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_network_service.cc View 1 2 10 chunks +50 lines, -15 lines 0 comments Download
M content/browser/loader/url_loader_request_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_job_wrapper.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
kinuko
PTL
3 years, 6 months ago (2017-06-07 13:58:50 UTC) #5
jam
lgtm
3 years, 6 months ago (2017-06-07 17:18:46 UTC) #12
kinuko
Hi Yuzhu, would something like this work?
3 years, 6 months ago (2017-06-07 23:46:35 UTC) #14
yzshen1
LGTM I think this works. Although it has extra cost of chaining two URLLoader, I ...
3 years, 6 months ago (2017-06-07 23:51:35 UTC) #15
kinuko
On 2017/06/07 23:51:35, yzshen1 wrote: > LGTM > > I think this works. Although it ...
3 years, 6 months ago (2017-06-07 23:58:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931623002/40001
3 years, 6 months ago (2017-06-08 04:37:59 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 04:42:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/acde73a7fa15b3877a342ddd8c5d...

Powered by Google App Engine
This is Rietveld 408576698