Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3633)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2931573003: Fix stability and data racing issues, coalesce more updates for JumpList (Closed)
Patch Set: Remove refcounting for jumplist KeyedService, fix nits. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index 0b714ec406baa1d2fb13518c16c3224fc18154b8..a57bbff8aca278fb2a23ff0e0066d36627237b33 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -689,7 +689,7 @@ class BrowserView : public BrowserWindow,
std::unique_ptr<LoadCompleteListener> load_complete_listener_;
// The custom JumpList for Windows 7.
grt (UTC plus 2) 2017/06/12 20:43:38 nit: remove "7" since the jumplist applies to all
chengx 2017/06/12 22:05:30 Done.
- scoped_refptr<JumpList> jumplist_;
+ JumpList* jumplist_;
grt (UTC plus 2) 2017/06/12 20:43:38 = nullptr;
chengx 2017/06/12 22:05:30 Done.
#endif
// The timer used to update frames for the Loading Animation.
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698