chrome/browser/ui/views/frame/browser_view.cc - Issue 2931573003: Fix stability and data racing issues, coalesce more updates for JumpList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2931573003: Fix stability and data racing issues, coalesce more updates for JumpList (Closed)

Patch Set: Remove refcounting for jumplist KeyedService, fix nits. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index e9fe68b85300acb519b0cdb11b14d49ebdf14321..51393b8bff9885160bcb476a107d6d91c2b2bd5d 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2178,7 +2178,6 @@ void BrowserView::LoadingAnimationCallback() {

void BrowserView::OnLoadCompleted() {

#if defined(OS_WIN)

- DCHECK(!jumplist_.get());

grt (UTC plus 2) 2017/06/12 20:43:38 this was failing because the member was uninitiali

chengx 2017/06/12 22:05:30 Done.

jumplist_ = JumpListFactory::GetForProfile(browser_->profile());

#endif

}