Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2931513003: Recreate MediaPermissionDispatcher's service connection on navigation (Closed)

Created:
3 years, 6 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Recreate MediaPermissionDispatcher's service connection on navigation In r470992 we started closing PermissionService connections on navigation however the lifetime of a MediaPermissionDispatcher is that of the frame it is attached to. Since frames can be navigated the service connection must be re-established after it is closed. To prevent a race between the browser-side close and the navigation committing in the renderer we close the connection from that side as well. Bug: 725038 Change-Id: Id5d9d03537c7b7ee0997d77da4bafed055686521 Reviewed-on: https://chromium-review.googlesource.com/513387 Reviewed-by: Daniel Cheng <dcheng@chromium.org>; Reviewed-by: Nick Carter <nick@chromium.org>; Commit-Queue: Reilly Grant <reillyg@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#477363} Review-Url: https://codereview.chromium.org/2931513003 . Cr-Commit-Position: refs/branch-heads/3112@{#231} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/4d2aa441f353f892cda7029b5bbd908777536010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -11 lines) Patch
M content/renderer/media/media_permission_dispatcher.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/media/media_permission_dispatcher.cc View 5 chunks +31 lines, -11 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
3 years, 6 months ago (2017-06-07 19:58:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d2aa441f353f892cda7029b5bbd908777536010.

Powered by Google App Engine
This is Rietveld 408576698