Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2931483003: [deoptimizer] Teach the Deoptimizer about bound functions. (Closed)

Created:
3 years, 6 months ago by Benedikt Meurer
Modified:
3 years, 6 months ago
Reviewers:
Jarin, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Teach the Deoptimizer about bound functions. The inlining of Function.prototype.bind can lead to escape analyzed bound functions, which weren't handled by the Deoptimizer previously. BUG=chromium:729573 R=jarin@chromium.org,cbruni@chromium.org Review-Url: https://codereview.chromium.org/2931483003 Cr-Commit-Position: refs/heads/master@{#45751} Committed: https://chromium.googlesource.com/v8/v8/+/337bb36e5251efd0db641a9f200d19cb101229fa

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add moar test covfefe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M src/deoptimizer.cc View 2 chunks +17 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-729573-1.js View 1 1 chunk +67 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-729573-2.js View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 6 months ago (2017-06-07 05:36:52 UTC) #1
Jarin
lgtm https://codereview.chromium.org/2931483003/diff/1/test/mjsunit/regress/regress-crbug-729573.js File test/mjsunit/regress/regress-crbug-729573.js (right): https://codereview.chromium.org/2931483003/diff/1/test/mjsunit/regress/regress-crbug-729573.js#newcode11 test/mjsunit/regress/regress-crbug-729573.js:11: if (!a) return a; Please, write a test ...
3 years, 6 months ago (2017-06-07 05:42:47 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/2931483003/diff/1/test/mjsunit/regress/regress-crbug-729573.js File test/mjsunit/regress/regress-crbug-729573.js (right): https://codereview.chromium.org/2931483003/diff/1/test/mjsunit/regress/regress-crbug-729573.js#newcode11 test/mjsunit/regress/regress-crbug-729573.js:11: if (!a) return a; On 2017/06/07 05:42:46, Jarin wrote: ...
3 years, 6 months ago (2017-06-07 05:55:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931483003/20001
3 years, 6 months ago (2017-06-07 05:55:55 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 06:25:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/337bb36e5251efd0db641a9f200d19cb101...

Powered by Google App Engine
This is Rietveld 408576698