[ActiveSuggestionMarker #2.5] Handle ActiveSuggestionMarkers for accessibility

ui/accessibility/ax_enums.idl

Index: ui/accessibility/ax_enums.idl
diff --git a/ui/accessibility/ax_enums.idl b/ui/accessibility/ax_enums.idl
index 013fb7e109f3478a3d1386a71d8f76cb0687a74e..ff90151f9f1b7392b43eee6296e94e276773e852 100644
--- a/ui/accessibility/ax_enums.idl
+++ b/ui/accessibility/ax_enums.idl
@@ -541,7 +541,17 @@
     text_match = 4,
     spelling_text_match = 5,
     grammar_text_match = 6,
-    spelling_grammar_text_match = 7
+    spelling_grammar_text_match = 7,
+    // DocumentMarker::MarkerType::Composition = 8 is ignored for accessibility

[rlanday, 2017/06/06 19:27:41]

Am I updating this file correctly? It's a little weird since we're skipping over
Composition markers. I could re-order the list of MarkerTypes to put Composition
on the bottom again, but it doesn't really seem right that the ordering should
be constrained in this way (e.g. what happens if some other DocumentMarker use
case wants the enum in a different order?).

This seems to get exponentially more difficult to maintain as we add more
MarkerTypes. I'm planning to add at least one more after this.

[dmazzoni, 2017/06/06 19:44:32]

You're right, this doesn't scale.

Please add a TODO for me and/or nektar@ to fix this.
Thanks for adding the permutations in the meantime.

+    // purposes
+    active_suggestion = 16,
+    spelling_active_suggestion = 17,
+    grammar_active_suggestion = 18,
+    spelling_grammar_active_suggestion = 19,
+    text_match_active_suggestion = 20,
+    spelling_text_match_active_suggestion = 21,
+    grammar_text_match_active_suggestion = 22,
+    spelling_grammar_text_match_active_suggestion = 23
   };
 
   enum AXTextDirection {