Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)
Patch Set: Reduce code duplication in TextSuggestionController Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml
diff --git a/content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml b/content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml
new file mode 100644
index 0000000000000000000000000000000000000000..36cc8278d626d0050b2203abce3ac82c00739434
--- /dev/null
+++ b/content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<!-- Based on Android's text_edit_suggestion_container_material.xml -->
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:tools="http://schemas.android.com/tools"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content">
+ <!-- On Lollipop and later (this file), we draw a drop shadow using elevation.
+ On pre-Lollipop, we instead draw the drop shadow using
+ @drawable/dropdown_popup_background. -->
+ <LinearLayout
+ style="@style/TextSuggestionWindowContainer"
+ android:id="@+id/suggestionWindowContainer"
+ android:background="@drawable/floating_popup_background_light"
+ android:elevation="2dp"
+ tools:ignore="UselessParent">
Theresa 2017/07/18 15:37:51 Can you please try removing ReleativeLayout instea
rlanday 2017/07/19 00:23:55 Ok, I experimented a bit and found a way to do thi
+ <ListView
+ android:id="@+id/suggestionContainer"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content" />
+ </LinearLayout>
+</RelativeLayout>

Powered by Google App Engine
This is Rietveld 408576698