content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml - Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)

Patch Set: Reduce code duplication in TextSuggestionController Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/public/android/java/res/drawable/floating_popup_background_light.xml ('k') | content/public/android/java/res/layout/text_edit_suggestion_container.xml » ('j') | content/public/android/java/res/layout/text_edit_suggestion_container.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Based on Android's text_edit_suggestion_container_material.xml -->

	7 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:tools="http://schemas.android.com/tools"

	9 android:layout_width="wrap_content"

	10 android:layout_height="wrap_content">

	11 <!-- On Lollipop and later (this file), we draw a drop shadow using elevatio n.

	12 On pre-Lollipop, we instead draw the drop shadow using

	13 @drawable/dropdown_popup_background. -->

	14 <LinearLayout

	15 style="@style/TextSuggestionWindowContainer"

	16 android:id="@+id/suggestionWindowContainer"

	17 android:background="@drawable/floating_popup_background_light"

	18 android:elevation="2dp"

	19 tools:ignore="UselessParent">
	Theresa 2017/07/18 15:37:51 Can you please try removing ReleativeLayout instea Can you please try removing ReleativeLayout instead of suppressing the "UselessParent" warning? rlanday 2017/07/19 00:23:55 Ok, I experimented a bit and found a way to do thi Show quoted text On 2017/07/18 at 15:37:51, Theresa wrote: > Can you please try removing ReleativeLayout instead of suppressing the "UselessParent" warning? Ok, I experimented a bit and found a way to do this. I was also able to get rid of the margin you didn't like (I still have it as a dimension so we can keep the menu from appearing too close to the top/bottom of the window, to match the existing Android menu's behavior). This lets us consolidate mContentView and mContainerView.
	20 <ListView

	21 android:id="@+id/suggestionContainer"

	22 android:layout_width="match_parent"

	23 android:layout_height="wrap_content" />

	24 </LinearLayout>

	25 </RelativeLayout>

OLD	NEW