Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)
Patch Set: Use correct base commit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index 2bdb9123ea29ecd7974fc3feb198422ca43460e8..8a8cc30b4b91f03ba36d0a1674f99535ca413fd8 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -37,6 +37,7 @@
#include "core/editing/RenderedPosition.h"
#include "core/editing/iterators/TextIterator.h"
#include "core/editing/markers/DocumentMarkerController.h"
+#include "core/editing/suggestion/TextSuggestionController.h"
#include "core/events/Event.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/LocalFrameView.h"
@@ -279,6 +280,12 @@ bool SelectionController::HandleSingleClick(
kCharacterGranularity,
is_handle_visible ? HandleVisibility::kVisible
: HandleVisibility::kNotVisible);
+
+ if (event.Event().FromTouch()) {
+ frame_->GetTextSuggestionController().HandlePotentialMisspelledWordTap(
rlanday 2017/06/23 23:59:30 I think this should probably be gated to only run
+ visible_pos);
+ }
+
return false;
}

Powered by Google App Engine
This is Rietveld 408576698