third_party/WebKit/Source/core/editing/Position.cpp - Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Position.cpp

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)

Patch Set: Use correct base commit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Position.cpp

diff --git a/third_party/WebKit/Source/core/editing/Position.cpp b/third_party/WebKit/Source/core/editing/Position.cpp

index 6b58eb430417d009ca5569b0c701b265a1a73bdf..84a71c086463700e087b855d55c7e1cb7c1c33f0 100644

--- a/third_party/WebKit/Source/core/editing/Position.cpp

+++ b/third_party/WebKit/Source/core/editing/Position.cpp

@@ -150,6 +150,7 @@ PositionTemplate<Strategy>::PositionTemplate(const PositionTemplate& other)

template <typename Strategy>

Node* PositionTemplate<Strategy>::ComputeContainerNode() const {

+ TRACE_EVENT0("blink", "Position::ComputeContainerNode");

if (!anchor_node_)

return 0;

@@ -181,6 +182,7 @@ static int MinOffsetForNode(Node* anchor_node, int offset) {

template <typename Strategy>

int PositionTemplate<Strategy>::ComputeOffsetInContainerNode() const {

+ TRACE_EVENT0("blink", "Position::ComputeOffsetInContainerNode");

if (!anchor_node_)

return 0;