Add support for Android spellcheck menu in Chrome/WebViews

content/public/android/java/res/layout/text_edit_suggestion_container.xml

Index: content/public/android/java/res/layout/text_edit_suggestion_container.xml
diff --git a/content/public/android/java/res/layout/text_edit_suggestion_container.xml b/content/public/android/java/res/layout/text_edit_suggestion_container.xml
new file mode 100644
index 0000000000000000000000000000000000000000..f656d9b8c0f4c742e5eeb3958ee1a042056cbf85
--- /dev/null
+++ b/content/public/android/java/res/layout/text_edit_suggestion_container.xml
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

[Ted C, 2017/06/21 17:59:21]

Why do you need this outer relativelayout?

[rlanday, 2017/06/28 01:35:33]

I was copying from this file:
https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master...

Seems if I try to remove the outer RelativeLayout,
mContainerView.getLayoutParams() returns a null reference. Does
LinearLayout.getLayoutParams() not work unless it's inside a RelativeLayout?

+    xmlns:tools="http://schemas.android.com/tools"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content">
+    <LinearLayout
+        android:id="@+id/suggestionWindowContainer"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:background="@drawable/floating_popup_background_light"
+        android:elevation="2dp"

[Ted C, 2017/06/21 17:59:21]

elevation only works on newer versions of android, what happens if you run this
on KK?  Does it look ok?

[rlanday, 2017/06/28 01:35:33]

It looks flat. We might want to add a border so the menu doesn't look invisible
on a white background. I guess I'll talk to hannahs@ about this

+        android:layout_margin="20dp"
+        android:orientation="vertical"
+        android:divider="?android:attr/listDivider"
+        android:showDividers="middle"
+        tools:ignore="UselessParent">
+        <ListView
+            android:id="@+id/suggestionContainer"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:paddingTop="4dp"
+            android:paddingBottom="0dp" />
+        <LinearLayout

[Ted C, 2017/06/21 17:59:21]

Why do you need this LinearLayout?  Is it to have the divider between the two
sections?

Could you get the divider by doing:
<View android:background="?android:attr/listDivider" />

Then adding the TextViews to this linearlayout?  Ideally, you keep your views as
shallow as possible.

[rlanday, 2017/06/28 01:35:33]

It's so we don't get a divider between "Add to Dictionary" and "Delete".

And yeah, removing the extra LinearLayout and adding the divider like that
works.

+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:orientation="vertical">
+          <TextView
+              style="@style/TextSuggestionButton"
+              android:id="@+id/addToDictionaryButton"
+              android:text="@string/add_to_dictionary" />
+          <TextView
+              style="@style/TextSuggestionButton"
+              android:id="@+id/deleteButton"
+              android:text="@string/delete_suggestion_text" />
+        </LinearLayout>
+    </LinearLayout>
+</RelativeLayout>