content/public/android/java/res/layout/text_edit_suggestion_container.xml - Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews

Side by Side Diff: content/public/android/java/res/layout/text_edit_suggestion_container.xml

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)

Patch Set: Actually split off LayoutTheme changes Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/browser/android/text_suggestion_host_android.cc ('K') | « content/public/android/java/res/drawable/floating_popup_background_light.xml ('k') | content/public/android/java/res/layout/text_edit_suggestion_item.xml » ('j') | content/public/android/java/res/values-v17/styles.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
	Ted C 2017/06/21 17:59:21 Why do you need this outer relativelayout? Why do you need this outer relativelayout? rlanday 2017/06/28 01:35:33 I was copying from this file: https://android.goog Show quoted text On 2017/06/21 at 17:59:21, Ted C wrote: > Why do you need this outer relativelayout? I was copying from this file: https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master... Seems if I try to remove the outer RelativeLayout, mContainerView.getLayoutParams() returns a null reference. Does LinearLayout.getLayoutParams() not work unless it's inside a RelativeLayout?
	7 xmlns:tools="http://schemas.android.com/tools"

	8 android:layout_width="wrap_content"

	9 android:layout_height="wrap_content">

	10 <LinearLayout

	11 android:id="@+id/suggestionWindowContainer"

	12 android:layout_width="match_parent"

	13 android:layout_height="wrap_content"

	14 android:background="@drawable/floating_popup_background_light"

	15 android:elevation="2dp"
	Ted C 2017/06/21 17:59:21 elevation only works on newer versions of android, elevation only works on newer versions of android, what happens if you run this on KK? Does it look ok? rlanday 2017/06/28 01:35:33 It looks flat. We might want to add a border so th Show quoted text On 2017/06/21 at 17:59:21, Ted C wrote: > elevation only works on newer versions of android, what happens if you run this on KK? Does it look ok? It looks flat. We might want to add a border so the menu doesn't look invisible on a white background. I guess I'll talk to hannahs@ about this
	16 android:layout_margin="20dp"

	17 android:orientation="vertical"

	18 android:divider="?android:attr/listDivider"

	19 android:showDividers="middle"

	20 tools:ignore="UselessParent">

	21 <ListView

	22 android:id="@+id/suggestionContainer"

	23 android:layout_width="match_parent"

	24 android:layout_height="wrap_content"

	25 android:paddingTop="4dp"

	26 android:paddingBottom="0dp" />

	27 <LinearLayout
	Ted C 2017/06/21 17:59:21 Why do you need this LinearLayout? Is it to have Why do you need this LinearLayout? Is it to have the divider between the two sections? Could you get the divider by doing: <View android:background="?android:attr/listDivider" /> Then adding the TextViews to this linearlayout? Ideally, you keep your views as shallow as possible. rlanday 2017/06/28 01:35:33 It's so we don't get a divider between "Add to Dic Show quoted text On 2017/06/21 at 17:59:21, Ted C wrote: > Why do you need this LinearLayout? Is it to have the divider between the two sections? > > Could you get the divider by doing: > <View android:background="?android:attr/listDivider" /> > > Then adding the TextViews to this linearlayout? Ideally, you keep your views as shallow as possible. It's so we don't get a divider between "Add to Dictionary" and "Delete". And yeah, removing the extra LinearLayout and adding the divider like that works.
	28 android:layout_width="wrap_content"

	29 android:layout_height="wrap_content"

	30 android:orientation="vertical">

	31 <TextView

	32 style="@style/TextSuggestionButton"

	33 android:id="@+id/addToDictionaryButton"

	34 android:text="@string/add_to_dictionary" />

	35 <TextView

	36 style="@style/TextSuggestionButton"

	37 android:id="@+id/deleteButton"

	38 android:text="@string/delete_suggestion_text" />

	39 </LinearLayout>

	40 </LinearLayout>

	41 </RelativeLayout>

OLD	NEW