Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: content/public/android/java/res/layout/text_edit_suggestion_container.xml

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)
Patch Set: Actually split off LayoutTheme changes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. -->
5
6 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
Ted C 2017/06/21 17:59:21 Why do you need this outer relativelayout?
rlanday 2017/06/28 01:35:33 I was copying from this file: https://android.goog
7 xmlns:tools="http://schemas.android.com/tools"
8 android:layout_width="wrap_content"
9 android:layout_height="wrap_content">
10 <LinearLayout
11 android:id="@+id/suggestionWindowContainer"
12 android:layout_width="match_parent"
13 android:layout_height="wrap_content"
14 android:background="@drawable/floating_popup_background_light"
15 android:elevation="2dp"
Ted C 2017/06/21 17:59:21 elevation only works on newer versions of android,
rlanday 2017/06/28 01:35:33 It looks flat. We might want to add a border so th
16 android:layout_margin="20dp"
17 android:orientation="vertical"
18 android:divider="?android:attr/listDivider"
19 android:showDividers="middle"
20 tools:ignore="UselessParent">
21 <ListView
22 android:id="@+id/suggestionContainer"
23 android:layout_width="match_parent"
24 android:layout_height="wrap_content"
25 android:paddingTop="4dp"
26 android:paddingBottom="0dp" />
27 <LinearLayout
Ted C 2017/06/21 17:59:21 Why do you need this LinearLayout? Is it to have
rlanday 2017/06/28 01:35:33 It's so we don't get a divider between "Add to Dic
28 android:layout_width="wrap_content"
29 android:layout_height="wrap_content"
30 android:orientation="vertical">
31 <TextView
32 style="@style/TextSuggestionButton"
33 android:id="@+id/addToDictionaryButton"
34 android:text="@string/add_to_dictionary" />
35 <TextView
36 style="@style/TextSuggestionButton"
37 android:id="@+id/deleteButton"
38 android:text="@string/delete_suggestion_text" />
39 </LinearLayout>
40 </LinearLayout>
41 </RelativeLayout>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698