Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: extensions/renderer/argument_spec.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/argument_spec.cc
diff --git a/extensions/renderer/argument_spec.cc b/extensions/renderer/argument_spec.cc
index 70afeba1a9ffd5603aab9834ec7909f208fcb0b3..1ecb1dadcdc3162f3a4f1337245a244f7edae2e6 100644
--- a/extensions/renderer/argument_spec.cc
+++ b/extensions/renderer/argument_spec.cc
@@ -618,11 +618,11 @@ bool ArgumentSpec::ParseArgumentToAny(v8::Local<v8::Context> context,
std::string* error) const {
DCHECK(type_ == ArgumentType::ANY || type_ == ArgumentType::BINARY);
if (out_value) {
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
+ std::unique_ptr<content::V8ValueConverter> converter =
+ content::V8ValueConverter::Create();
converter->SetStripNullFromObjects(!preserve_null_);
- std::unique_ptr<base::Value> converted(
- converter->FromV8Value(value, context));
+ std::unique_ptr<base::Value> converted =
+ converter->FromV8Value(value, context);
if (!converted) {
*error = api_errors::UnserializableValue();
return false;

Powered by Google App Engine
This is Rietveld 408576698