Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: extensions/renderer/api_signature.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_signature.cc
diff --git a/extensions/renderer/api_signature.cc b/extensions/renderer/api_signature.cc
index e15a53f80392707341e8d3c536a8b3a6658bf49f..eec382dcd5262ffd7a1b2ad6c5b04cdc136a3a7a 100644
--- a/extensions/renderer/api_signature.cc
+++ b/extensions/renderer/api_signature.cc
@@ -324,8 +324,8 @@ bool APISignature::ConvertArgumentsIgnoringSchema(
}
auto json = base::MakeUnique<base::ListValue>();
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
+ std::unique_ptr<content::V8ValueConverter> converter =
+ content::V8ValueConverter::Create();
converter->SetFunctionAllowed(true);
for (size_t i = 0; i < size; ++i) {
std::unique_ptr<base::Value> converted =

Powered by Google App Engine
This is Rietveld 408576698