Split out code to be shared between CheckedNumeric and ClampedNumeric

Split out code to be shared between CheckedNumeric and ClampedNumeric

BUG=672489
Review-Url: https://codereview.chromium.org/2931323002
Cr-Commit-Position: refs/heads/master@{#478803}
Committed: https://chromium.googlesource.com/chromium/src/+/6a2c67b927972a2b38446154bfe9784313701d8c

[jschuh, 2017-06-12 00:41:55]

The CQ bit was checked by jschuh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 00:42:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 02:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 02:51:46]

Dry run: This issue passed the CQ dry run.

[jschuh, 2017-06-12 03:00:43]

jschuh@chromium.org changed reviewers:
+ brucedawson@chromium.org

[jschuh, 2017-06-12 03:00:43]

Hey Bruce, this is just splitting out files so I can better share code between
the ClampedNumeric and SaturatedNumeric CLs I'm working on.

[jschuh, 2017-06-12 03:01:27]

The CQ bit was checked by jschuh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 03:01:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 05:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 05:07:23]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-06-12 21:09:22]

Just one real question, but lgtm

https://codereview.chromium.org/2931323002/diff/40001/base/numerics/checked_m...
File base/numerics/checked_math.h (left):

https://codereview.chromium.org/2931323002/diff/40001/base/numerics/checked_m...
base/numerics/checked_math.h:302: };
Who *wrote* the previous version? Must have been a JavaScript programmer who was
taught to go crazy with semi-colons.

https://codereview.chromium.org/2931323002/diff/40001/base/numerics/checked_m...
File base/numerics/checked_math_impl.h (left):

https://codereview.chromium.org/2931323002/diff/40001/base/numerics/checked_m...
base/numerics/checked_math_impl.h:24: // platform/architecture and replaced with
potentially faster implementations.
This comment now gone from everywhere. Intentional?

[jschuh, 2017-06-12 21:19:21]

https://codereview.chromium.org/2931323002/diff/40001/base/numerics/checked_m...
File base/numerics/checked_math.h (left):

https://codereview.chromium.org/2931323002/diff/40001/base/numerics/checked_m...
base/numerics/checked_math.h:302: };
On 2017/06/12 21:09:22, brucedawson wrote:
> Who *wrote* the previous version? Must have been a JavaScript programmer who
was
> taught to go crazy with semi-colons.

Let's not dwell on that, and instead just be happy that our current tooling is
so good at finding such things. :P

https://codereview.chromium.org/2931323002/diff/40001/base/numerics/checked_m...
File base/numerics/checked_math_impl.h (left):

https://codereview.chromium.org/2931323002/diff/40001/base/numerics/checked_m...
base/numerics/checked_math_impl.h:24: // platform/architecture and replaced with
potentially faster implementations.
On 2017/06/12 21:09:22, brucedawson wrote:
> This comment now gone from everywhere. Intentional?

Yup. The move makes the code split clearer, and once I added the clang/gcc
builtins last year it kinda moots the other part.

[jschuh, 2017-06-12 22:51:22]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2017-06-12 22:52:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:57:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497307882179440,
"parent_rev": "7b56a5733a6ded284c245018071328dbb99aadb5", "commit_rev":
"07c6ab9d0ae923d9d66a5466e3f3b7d7d273ce9c"}

[commit-bot: I haz the power, 2017-06-12 22:57:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497307882179440,
"parent_rev": "96e2b7d0f820bfa4fb3f2b2aeb58debfcb5e5bf4", "commit_rev":
"6a2c67b927972a2b38446154bfe9784313701d8c"}

[commit-bot: I haz the power, 2017-06-12 22:57:49]

Description was changed from

==========
Split out code to be shared between CheckedNumeric and ClampedNumeric

BUG=672489
==========

to

==========
Split out code to be shared between CheckedNumeric and ClampedNumeric

BUG=672489

Review-Url: https://codereview.chromium.org/2931323002
Cr-Commit-Position: refs/heads/master@{#478803}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a2c67b927972a2b38446154bfe9...
==========

[commit-bot: I haz the power, 2017-06-12 22:57:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6a2c67b927972a2b38446154bfe9...