Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2931313003: Remove SHA-1 metrics (Closed)

Created:
3 years, 6 months ago by Ryan Sleevi
Modified:
3 years, 6 months ago
Reviewers:
Ilya Sherman, mmenke
CC:
chromium-reviews, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, rdsmith+watch_chromium.org, loading-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SHA-1 metrics SHA-1 was successfully disabled by default in M56 for publicly trusted CAs. Remove the metrics that measured the impact of that disabling. BUG=703458 Review-Url: https://codereview.chromium.org/2931313003 Cr-Commit-Position: refs/heads/master@{#478730} Committed: https://chromium.googlesource.com/chromium/src/+/5097bdd411fe4f7e557ac0fb9dcc3074954e0cc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -59 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +0 lines, -59 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ryan Sleevi
mmenke: OWNERS for c/b/l isherman: OWNERS for metrics Cleaning up old metrics
3 years, 6 months ago (2017-06-12 15:44:09 UTC) #2
mmenke
On 2017/06/12 15:44:09, Ryan Sleevi wrote: > mmenke: OWNERS for c/b/l > isherman: OWNERS for ...
3 years, 6 months ago (2017-06-12 15:52:20 UTC) #3
Ilya Sherman
histograms.xml lgtm; thanks for the cleanup!
3 years, 6 months ago (2017-06-12 18:11:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931313003/1
3 years, 6 months ago (2017-06-12 18:16:41 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 19:58:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5097bdd411fe4f7e557ac0fb9dcc...

Powered by Google App Engine
This is Rietveld 408576698