Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2931283002: android: Attempt to fix ARMv6 cronet build with clang. (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Attempt to fix ARMv6 cronet build with clang. BUG=732100 TBR=agrieve Review-Url: https://codereview.chromium.org/2931283002 Cr-Commit-Position: refs/heads/master@{#478529} Committed: https://chromium.googlesource.com/chromium/src/+/c27622a3322afd5b495e0ed9aaa598d6027e41be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
3 years, 6 months ago (2017-06-11 02:18:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931283002/1
3 years, 6 months ago (2017-06-11 02:18:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c27622a3322afd5b495e0ed9aaa598d6027e41be
3 years, 6 months ago (2017-06-11 03:21:58 UTC) #8
agrieve
3 years, 6 months ago (2017-06-12 14:23:23 UTC) #9
Message was sent while issue was closed.
On 2017/06/11 03:21:58, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/c27622a3322afd5b495e0ed9aaa5...

lgtm

Powered by Google App Engine
This is Rietveld 408576698