Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2931063002: swarming: Add more documentation to task messages (Closed)

Created:
3 years, 6 months ago by M-A Ruel
Modified:
3 years, 6 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: Add more documentation to task messages In particular note right away that NewTaskRequest.dimensions is an AND: all values specified must match. R=vadimsh@chromium.org BUG=728124 Review-Url: https://codereview.chromium.org/2931063002 Committed: https://github.com/luci/luci-py/commit/6ad3c41630bbc5371ed955c750a2116c5d0b0a2a

Patch Set 1 #

Total comments: 6

Patch Set 2 : doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M appengine/swarming/swarming_rpcs.py View 1 4 chunks +53 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
M-A Ruel
3 years, 6 months ago (2017-06-09 01:51:06 UTC) #1
Vadim Sh.
https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming_rpcs.py File appengine/swarming/swarming_rpcs.py (right): https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming_rpcs.py#newcode196 appengine/swarming/swarming_rpcs.py:196: # packages do not expire from the serve. server ...
3 years, 6 months ago (2017-06-09 19:07:12 UTC) #2
Vadim Sh.
lgtm
3 years, 6 months ago (2017-06-09 19:07:21 UTC) #3
M-A Ruel
https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming_rpcs.py File appengine/swarming/swarming_rpcs.py (right): https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming_rpcs.py#newcode196 appengine/swarming/swarming_rpcs.py:196: # packages do not expire from the serve. On ...
3 years, 6 months ago (2017-06-09 19:43:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931063002/20001
3 years, 6 months ago (2017-06-09 19:43:38 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 19:47:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/6ad3c41630bbc5371ed955c750a2116c5d0b0a2a

Powered by Google App Engine
This is Rietveld 408576698