swarming: Add more documentation to task messages

swarming: Add more documentation to task messages

In particular note right away that NewTaskRequest.dimensions is an AND: all
values specified must match.

R=vadimsh@chromium.org
BUG=728124
Review-Url: https://codereview.chromium.org/2931063002
Committed: https://github.com/luci/luci-py/commit/6ad3c41630bbc5371ed955c750a2116c5d0b0a2a

[Vadim Sh., 2017-06-09 19:07:12]

https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_rpcs.py (right):

https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_rpcs.py:196: # packages do not expire from the
serve.
server

https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_rpcs.py:205: # Environment variables to specify to
the bot.
"to specify to the bot" sounds odd

"to set when running the task"?

https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_rpcs.py:244: # the server about reentrancy.
what is reentrancy?

[Vadim Sh., 2017-06-09 19:07:21]

lgtm

[M-A Ruel, 2017-06-09 19:43:28]

https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_rpcs.py (right):

https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_rpcs.py:196: # packages do not expire from the
serve.
On 2017/06/09 19:07:11, Vadim Sh. wrote:
> server

Done.

https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_rpcs.py:205: # Environment variables to specify to
the bot.
On 2017/06/09 19:07:11, Vadim Sh. wrote:
> "to specify to the bot" sounds odd
> 
> "to set when running the task"?

Done.

https://codereview.chromium.org/2931063002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_rpcs.py:244: # the server about reentrancy.
On 2017/06/09 19:07:11, Vadim Sh. wrote:
> what is reentrancy?

It's when it reenters itself by the wrong side.
🤡

Added a moot explanation.

[M-A Ruel, 2017-06-09 19:43:32]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2017-06-09 19:43:32]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2931063002/#ps20001
(title: "doc")

[commit-bot: I haz the power, 2017-06-09 19:43:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 19:47:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497037412100800,
"parent_rev": "96a8b5b33cf41f5051e10b022cf05a5b6e2ea64c", "commit_rev":
"6ad3c41630bbc5371ed955c750a2116c5d0b0a2a"}

[commit-bot: I haz the power, 2017-06-09 19:47:53]

Description was changed from

==========
swarming: Add more documentation to task messages

In particular note right away that NewTaskRequest.dimensions is an AND: all
values specified must match.

R=vadimsh@chromium.org
BUG=728124
==========

to

==========
swarming: Add more documentation to task messages

In particular note right away that NewTaskRequest.dimensions is an AND: all
values specified must match.

R=vadimsh@chromium.org
BUG=728124

Review-Url: https://codereview.chromium.org/2931063002
Committed:
https://github.com/luci/luci-py/commit/6ad3c41630bbc5371ed955c750a2116c5d0b0a2a
==========

[commit-bot: I haz the power, 2017-06-09 19:47:54]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/6ad3c41630bbc5371ed955c750a2116c5d0b0a2a