Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2931033004: [Payments] fix the bug which disappear card icon list. (Closed)

Created:
3 years, 6 months ago by Hwanseung Lee
Modified:
3 years, 6 months ago
Reviewers:
gogerald1
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] fix the bug which disappear card icon list. after change to gridview from LinearLayout in order to show icons as multi line, that Gridview was disappeared at some android version. it was reported at Jelly Bean, and i checked see same problem in lollipop. but Marshmallow and Nougat is fine. BUG=731164 Review-Url: https://codereview.chromium.org/2931033004 Cr-Commit-Position: refs/heads/master@{#478868} Committed: https://chromium.googlesource.com/chromium/src/+/d62ac9357b0b3eb4dc6d1cd5b49dadd4833c1aad

Patch Set 1 #

Patch Set 2 : [Payments] fix a bugs which #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ExpandableGridView.java View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Hwanseung Lee
@gogerald PTAL, thank you.
3 years, 6 months ago (2017-06-11 02:33:20 UTC) #11
gogerald1
lgtm, please explain a little more about what happened on what specific version of Android ...
3 years, 6 months ago (2017-06-12 17:04:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931033004/20001
3 years, 6 months ago (2017-06-13 01:22:30 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 02:20:58 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d62ac9357b0b3eb4dc6d1cd5b49d...

Powered by Google App Engine
This is Rietveld 408576698