[CrOS Tether] Invoke "network properties updated" observer function when Tether network properties …

[CrOS Tether] Invoke "network properties updated" observer function when Tether network properties change.

Previously, "network list" updates (i.e., updates which signify that networks were added/remvoed) were sent instead. This fixes an issue in which the settings UI was not properly updated.

BUG=672263, 726869
Review-Url: https://codereview.chromium.org/2931003002
Cr-Commit-Position: refs/heads/master@{#478428}
Committed: https://chromium.googlesource.com/chromium/src/+/e367383624db1b222482184a14bb6f534c9bcf09

[Kyle Horimoto, 2017-06-08 22:08:23]

khorimoto@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-06-09 15:39:32]

https://codereview.chromium.org/2931003002/diff/60001/chromeos/network/networ...
File chromeos/network/network_state_handler.cc (right):

https://codereview.chromium.org/2931003002/diff/60001/chromeos/network/networ...
chromeos/network/network_state_handler.cc:639:
NotifyNetworkPropertiesUpdated(tether_network_state);
Can't all of this just be:

if (wifi_network_state->tether_guid().empty() &&
    tether_network_state->tether_guid()) {
  return;
}

NotifyNetworkPropertiesUpdated(wifi_network_state);
NotifyNetworkPropertiesUpdated(tether_network_state);

https://codereview.chromium.org/2931003002/diff/60001/chromeos/network/networ...
chromeos/network/network_state_handler.cc:688:
NotifyNetworkPropertiesUpdated(tether_network_state);
Same here? Alternately this logic could be moved to a common commented method
and shared (passing empty strings for the new guids in the above case).

[Kyle Horimoto, 2017-06-09 17:18:34]

https://codereview.chromium.org/2931003002/diff/60001/chromeos/network/networ...
File chromeos/network/network_state_handler.cc (right):

https://codereview.chromium.org/2931003002/diff/60001/chromeos/network/networ...
chromeos/network/network_state_handler.cc:639:
NotifyNetworkPropertiesUpdated(tether_network_state);
On 2017/06/09 15:39:31, stevenjb wrote:
> Can't all of this just be:
> 
> if (wifi_network_state->tether_guid().empty() &&
>     tether_network_state->tether_guid()) {
>   return;
> }
> 
> NotifyNetworkPropertiesUpdated(wifi_network_state);
> NotifyNetworkPropertiesUpdated(tether_network_state);

Done.

https://codereview.chromium.org/2931003002/diff/60001/chromeos/network/networ...
chromeos/network/network_state_handler.cc:688:
NotifyNetworkPropertiesUpdated(tether_network_state);
On 2017/06/09 15:39:31, stevenjb wrote:
> Same here? Alternately this logic could be moved to a common commented method
> and shared (passing empty strings for the new guids in the above case).

Done, but I didn't create a shared function since I think it's a bit overkill.

[stevenjb, 2017-06-09 20:57:34]

lgtm

[Kyle Horimoto, 2017-06-09 20:58:30]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-06-09 20:58:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 21:43:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497041910577180,
"parent_rev": "478f3b20593b53ce53fb65e9b70fb3d59f15d17d", "commit_rev":
"e367383624db1b222482184a14bb6f534c9bcf09"}

[commit-bot: I haz the power, 2017-06-09 21:43:11]

Description was changed from

==========
[CrOS Tether] Invoke "network properties updated" observer function when Tether
network properties change.

Previously, "network list" updates (i.e., updates which signify that networks
were added/remvoed) were sent instead. This fixes an issue in which the settings
UI was not properly updated.

BUG=672263,726869
==========

to

==========
[CrOS Tether] Invoke "network properties updated" observer function when Tether
network properties change.

Previously, "network list" updates (i.e., updates which signify that networks
were added/remvoed) were sent instead. This fixes an issue in which the settings
UI was not properly updated.

BUG=672263,726869

Review-Url: https://codereview.chromium.org/2931003002
Cr-Commit-Position: refs/heads/master@{#478428}
Committed:
https://chromium.googlesource.com/chromium/src/+/e367383624db1b222482184a14bb...
==========

[commit-bot: I haz the power, 2017-06-09 21:43:18]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e367383624db1b222482184a14bb...