Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2930993004: Address additional analysis issues in the observatory codebase. (Closed)

Created:
3 years, 6 months ago by devoncarew
Modified:
3 years, 6 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Address additional analysis issues in the observatory codebase. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2ea426a50982a84efab0fccc0a1a64256c72603a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -127 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 4 chunks +10 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/async_next_test.dart View 2 chunks +11 lines, -12 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_exception_test.dart View 2 chunks +11 lines, -19 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_into_test.dart View 2 chunks +8 lines, -12 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_out_test.dart View 2 chunks +9 lines, -14 lines 0 comments Download
M runtime/observatory/tests/service/async_star_single_step_into_test.dart View 2 chunks +10 lines, -16 lines 0 comments Download
M runtime/observatory/tests/service/async_star_step_out_test.dart View 3 chunks +16 lines, -25 lines 0 comments Download
M runtime/observatory/tests/service/async_step_out_test.dart View 2 chunks +9 lines, -14 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_in_frame_with_scope_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/evaluate_with_scope_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/observatory/tests/service/get_native_allocation_samples_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 2 chunks +25 lines, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
devoncarew
Address a few more analysis issues in the observatory codebase: - a few cases of ...
3 years, 6 months ago (2017-06-09 21:19:51 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2930993004/diff/1/runtime/observatory/tests/service/service_test_common.dart File runtime/observatory/tests/service/service_test_common.dart (right): https://codereview.chromium.org/2930993004/diff/1/runtime/observatory/tests/service/service_test_common.dart#newcode19 runtime/observatory/tests/service/service_test_common.dart:19: class ScriptLineParser { Awesome!
3 years, 6 months ago (2017-06-12 16:02:12 UTC) #3
devoncarew
3 years, 6 months ago (2017-06-12 20:12:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ea426a50982a84efab0fccc0a1a64256c72603a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698