Address additional analysis issues in the observatory codebase.

runtime/observatory/tests/service/async_single_step_exception_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // VMOptions=--error_on_bad_type --error_on_bad_override  --verbose_debug --async_debugger
 
-import 'dart:async';
 import 'dart:developer';
-import 'package:observatory/models.dart' as M;
-import 'package:observatory/service_io.dart';
-import 'package:unittest/unittest.dart';
+import 'dart:io';
+
 import 'service_test_common.dart';
 import 'test_helper.dart';
 
-const LINE_A = 23;
-const LINE_B = 24;
-const LINE_C = 30;
-const LINE_D = 32;
-const LINE_E = 35;
-const LINE_F = 38;
-const LINE_G = 40;
-
 helper() async {
   print('helper'); // LINE_A.
   throw 'a'; // LINE_B.
   return null;
 }
 
 testMain() async {
   debugger();
   print('mmmmm'); // LINE_C.
   try {
     await helper(); // LINE_D.
   } catch (e) {
     // arrive here on error.
     print('error: $e'); // LINE_E.
   } finally {
     // arrive here in both cases.
     print('foo'); // LINE_F.
   }
   print('z'); // LINE_G.
 }
 
+final ScriptLineParser lineParser = new ScriptLineParser(Platform.script);
+
 var tests = [
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_C),
+  stoppedAtLine(lineParser.lineFor('LINE_C')),
   stepOver, // print.
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_D),
+  stoppedAtLine(lineParser.lineFor('LINE_D')),
   stepInto,
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_A),
+  stoppedAtLine(lineParser.lineFor('LINE_A')),
   stepOver, // print.
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_B), // throw 'a'.
+  stoppedAtLine(lineParser.lineFor('LINE_B')), // throw 'a'.
   stepInto, // exit helper via a throw.
   hasStoppedAtBreakpoint,
   stepInto, // exit helper via a throw.
   hasStoppedAtBreakpoint,
   stepInto, // step once from entry to main.
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_E), // print(error)
+  stoppedAtLine(lineParser.lineFor('LINE_E')), // print(error)
   stepOver,
   hasStoppedAtBreakpoint,
   stepOver,
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_F), // print(foo)
+  stoppedAtLine(lineParser.lineFor('LINE_F')), // print(foo)
   stepOver,
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_G), // print(z)
+  stoppedAtLine(lineParser.lineFor('LINE_G')), // print(z)
   resumeIsolate
 ];
 
 main(args) => runIsolateTests(args, tests, testeeConcurrent: testMain);