Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2930993002: Fix new build break on Windows with OpenVR. (Closed)

Created:
3 years, 6 months ago by billorr
Modified:
3 years, 6 months ago
Reviewers:
mthiesse, raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, feature-vr-reviews_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix new build break on Windows with OpenVR. BUG=730436 Review-Url: https://codereview.chromium.org/2930993002 Cr-Commit-Position: refs/heads/master@{#478193} Committed: https://chromium.googlesource.com/chromium/src/+/ba0495ce9770653cf13459d8a07727295d55fe1a

Patch Set 1 #

Patch Set 2 : Fix build break on Windows with OpenVR. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/permissions/permission_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/permissions/permission_manager_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M device/vr/openvr/openvr_gamepad_data_fetcher.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
billorr
raymes@, please review permission_manager mthiesse@, please review vr_tab_helper.cc
3 years, 6 months ago (2017-06-08 22:03:27 UTC) #4
raymes
lgtm
3 years, 6 months ago (2017-06-09 01:14:07 UTC) #7
mthiesse
lgtm
3 years, 6 months ago (2017-06-09 03:49:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930993002/20001
3 years, 6 months ago (2017-06-09 03:49:55 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 03:53:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba0495ce9770653cf13459d8a077...

Powered by Google App Engine
This is Rietveld 408576698