Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2930983002: Revert of chrome.webRequest support for ExtensionSettings (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chrome.webRequest support for ExtensionSettings (patchset #11 id:470001 of https://codereview.chromium.org/2495353003/ ) Reason for revert: Breaking ExtensionApiTestWithManagementPolicy.InitiatorProtectedByPolicy browser_test on multiple testers https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/1023 https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/1535 https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/31130 Original issue's description: > chrome.webRequest support for ExtensionSettings > -If URL or Origin matches an ExtensionSettings protected host, the event will not be dispatched to that extension / app. > > BUG=624649 > > Review-Url: https://codereview.chromium.org/2495353003 > Cr-Commit-Position: refs/heads/master@{#478018} > Committed: https://chromium.googlesource.com/chromium/src/+/ea0116aad7867695cb2e438d3546f148ea271858 TBR=jochen@chromium.org,mkwst@chromium.org,nrpeter@chromium.org,rdevlin.cronin@chromium.org,nrpeter@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624649 Review-Url: https://codereview.chromium.org/2930983002 Cr-Commit-Position: refs/heads/master@{#478091} Committed: https://chromium.googlesource.com/chromium/src/+/82f0ee0c65720a27a2a928bd0ff4017d52438b7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -347 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 4 chunks +1 line, -197 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc View 4 chunks +34 lines, -41 lines 0 comments Download
M chrome/browser/extensions/extension_with_management_policy_apitest.h View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_with_management_policy_apitest.cc View 2 chunks +0 lines, -26 lines 0 comments Download
D chrome/test/data/extensions/api_test/webrequest/policy_blocked/background.js View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/api_test/webrequest/policy_blocked/manifest.json View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/extensions/api_test/webrequest/policy_blocked/ref_remote_js.html View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/extensions/api_test/webrequest/policy_blocked/ref_remote_js.js View 1 chunk +0 lines, -11 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_permissions.h View 2 chunks +2 lines, -5 lines 0 comments Download
M extensions/browser/api/web_request/web_request_permissions.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 2 chunks +6 lines, -8 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Beam
Created Revert of chrome.webRequest support for ExtensionSettings
3 years, 6 months ago (2017-06-08 21:29:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930983002/1
3 years, 6 months ago (2017-06-08 21:30:16 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 21:31:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82f0ee0c65720a27a2a928bd0ff4...

Powered by Google App Engine
This is Rietveld 408576698