Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2930953002: MD Settings: Sort "other" search engines alphabetically. (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Sort "other" search engines alphabetically. This matches the behavior of old Options. BUG=730248 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930953002 Cr-Commit-Position: refs/heads/master@{#478107} Committed: https://chromium.googlesource.com/chromium/src/+/cdceb9213784adf9e87f5a68212b714dab455b4a

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M chrome/browser/resources/settings/search_engines_page/search_engines_page.js View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/search_engines_page_test.js View 1 7 chunks +42 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dpapad
Before/after screenshots at http://imgur.com/a/aJCRM.
3 years, 6 months ago (2017-06-08 21:07:36 UTC) #6
dschuyler
lgtm
3 years, 6 months ago (2017-06-08 22:17:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930953002/20001
3 years, 6 months ago (2017-06-08 22:29:32 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 22:39:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cdceb9213784adf9e87f5a68212b...

Powered by Google App Engine
This is Rietveld 408576698