Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3345)

Unified Diff: runtime/vm/scavenger.h

Issue 2930943002: Debug garbage collector does not correctly remove cross-gen garbage (Closed)
Patch Set: Rewrites Evacuate() to use one Scavenge() Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/scavenger.h
diff --git a/runtime/vm/scavenger.h b/runtime/vm/scavenger.h
index b0e5dca273c7805b3a95092376bbd693523c6f9e..c035f4a529928c0baaaab0cdf8d773558dc9e441 100644
--- a/runtime/vm/scavenger.h
+++ b/runtime/vm/scavenger.h
@@ -149,11 +149,7 @@ class Scavenger {
void Scavenge(bool invoke_api_callbacks);
// Promote all live objects.
- void Evacuate() {
- Scavenge();
- Scavenge();
- ASSERT(UsedInWords() == 0);
- }
+ void Evacuate();
// Accessors to generate code for inlined allocation.
uword* TopAddress() { return &top_; }
@@ -297,6 +293,8 @@ class Scavenger {
// The total size of external data associated with objects in this scavenger.
intptr_t external_size_;
+ bool failed_to_promote_;
+
friend class ScavengerVisitor;
friend class ScavengerWeakVisitor;

Powered by Google App Engine
This is Rietveld 408576698