runtime/vm/heap.cc - Issue 2930943002: Debug garbage collector does not correctly remove cross-gen garbage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/heap.cc

Issue 2930943002: Debug garbage collector does not correctly remove cross-gen garbage (Closed)

Patch Set: Rewrites Evacuate() to use one Scavenge() Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/heap.cc

diff --git a/runtime/vm/heap.cc b/runtime/vm/heap.cc

index a713a8cf8821ecc6a2134a2b7c624f1acec72bc8..1af43b9fbc59a8b07e2673d2c79444d73abc21c3 100644

--- a/runtime/vm/heap.cc

+++ b/runtime/vm/heap.cc

@@ -444,7 +444,7 @@ void Heap::CollectGarbage(Space space) {

void Heap::CollectAllGarbage() {

Thread* thread = Thread::Current();

- CollectNewSpaceGarbage(thread, kInvokeApiCallbacks, kFull);

+ new_space_.Evacuate();

rmacnak 2017/06/22 21:59:33 Add a comment here that we evacuate new space to d

danunez 2017/06/22 22:07:47 Done.

CollectOldSpaceGarbage(thread, kInvokeApiCallbacks, kFull);

}

« no previous file with comments | « no previous file | runtime/vm/heap_test.cc » ('j') | runtime/vm/scavenger.cc » ('J')