Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: runtime/vm/object_test.cc

Issue 2930943002: Debug garbage collector does not correctly remove cross-gen garbage (Closed)
Patch Set: Rewrites Evacuate() to use one Scavenge() Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index 6e8de6bbc95b272e6a257b5bf659a5b052e0e86f..fe3dc26121e28f5159d5bd02cca5f5fda1dd7849 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -3364,7 +3364,8 @@ ISOLATE_UNIT_TEST_CASE(WeakProperty_PreserveCrossGen) {
key ^= OneByteString::null();
value ^= OneByteString::null();
}
- isolate->heap()->CollectAllGarbage();
+ isolate->heap()->CollectGarbage(Heap::kNew);
+ isolate->heap()->CollectGarbage(Heap::kOld);
// Weak property key and value should survive due to cross-generation
// pointers.
EXPECT(weak.key() != Object::null());
@@ -3382,7 +3383,8 @@ ISOLATE_UNIT_TEST_CASE(WeakProperty_PreserveCrossGen) {
key ^= OneByteString::null();
value ^= OneByteString::null();
}
- isolate->heap()->CollectAllGarbage();
+ isolate->heap()->CollectGarbage(Heap::kNew);
+ isolate->heap()->CollectGarbage(Heap::kOld);
// Weak property key and value should survive due to cross-generation
// pointers.
EXPECT(weak.key() != Object::null());

Powered by Google App Engine
This is Rietveld 408576698