chrome/browser/guest_view/web_view/web_view_guest.cc - Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_isguest_chrome_callsites

Patch Set: Addressed comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/guest_view_manager.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/public/browser/render_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/web_view_guest.cc

diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc

index 3286f09b41a09e63a7dd305bf6e59110523b3ef6..35bd51ca3f0af73f0a824ef41a7be3be71267d88 100644

--- a/chrome/browser/guest_view/web_view/web_view_guest.cc

+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc

@@ -34,6 +34,7 @@

#include "content/public/browser/notification_source.h"

#include "content/public/browser/notification_types.h"

#include "content/public/browser/render_process_host.h"

+#include "content/public/browser/render_view_host.h"

#include "content/public/browser/resource_request_details.h"

#include "content/public/browser/site_instance.h"

#include "content/public/browser/storage_partition.h"

@@ -903,6 +904,8 @@ void WebViewGuest::UserAgentOverrideSet(const std::string& user_agent) {

}

void WebViewGuest::RenderViewReady() {

+ // The guest RenderView should always live in an isolated guest process.

+ CHECK(guest_web_contents()->GetRenderProcessHost()->IsIsolatedGuest());

Send(new ChromeViewMsg_SetName(guest_web_contents()->GetRoutingID(), name_));

}