content/public/browser/render_process_host.h - Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/render_process_host.h

Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_isguest_chrome_callsites

Patch Set: Addressed comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/public/test/mock_render_process_host.h » ('j') | content/public/test/mock_render_process_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/render_process_host.h

diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h

index 66a96eca5c6aca95d61c3ce68656669350f7c3fb..4e0bee4822b3a630f7181052408579ac5f141980 100644

--- a/content/public/browser/render_process_host.h

+++ b/content/public/browser/render_process_host.h

@@ -95,9 +95,11 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,

virtual void WidgetHidden() = 0;

virtual int VisibleWidgetCount() const = 0;

- // Indicates whether the current RenderProcessHost associated with a guest

- // renderer process.

- virtual bool IsGuest() const = 0;

+ // Indicates whether the current RenderProcessHost is associated with an

+ // isolated guest renderer process. Not all guest renderers are created equal.

+ // A guest, as indicated by BrowserPluginGuest::IsGuest, may coexist with

+ // other non-guest renderers in the same process if IsSIsolatedGuest is false.

nasko 2014/05/28 16:29:13 nit: IsIsolatedGuest is misspelled.

fsamuel 2014/05/28 16:37:01 Done.

+ virtual bool IsIsolatedGuest() const = 0;

// Returns the storage partition associated with this process.