Don't show "Save password" prompt for a failed login

components/password_manager/core/browser/password_manager.h

Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index f04087983bfc2fa6f8c36c178bc8906400ff0cbd..fc3a2a50b65d7bd6b3f8916250a5e1a0d303d20b 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -94,7 +94,8 @@ class PasswordManager : public LoginModel {
 
   // Handles password forms being rendered.
   void OnPasswordFormsRendered(
-      const std::vector<autofill::PasswordForm>& visible_forms);
+      const std::vector<autofill::PasswordForm>& visible_forms,
+      bool did_stop_loading);
 
   // Handles a password form being submitted.
   virtual void OnPasswordFormSubmitted(
@@ -182,6 +183,12 @@ class PasswordManager : public LoginModel {
   // Callbacks to be notified when a password form has been submitted.
   std::vector<PasswordSubmittedCallback> submission_callbacks_;
 
+  // Records all visible forms in a page. It starts storing when the first

[vabr (Chromium), 2014/06/11 08:22:12]

Please always make sure to give context, especially when using pronouns. (What
is "It"?) Suggested reformulation:

Records all visible forms seen during a page load, in all frames of the page.
When the page stops loading, the password manager checks if one of the recorded
forms matches the login form from the previous page (to see if the login was a
failure), and clears the vector.

+  // visible form is received. When the page stops loading, the password
+  // manager checks the stored visible forms to search for a match for the
+  // login form. It is cleared when a match is found or in the end of search.
+  std::vector<autofill::PasswordForm> all_visible_forms_;
+
   DISALLOW_COPY_AND_ASSIGN(PasswordManager);
 };