Don't show "Save password" prompt for a failed login

components/password_manager/core/browser/password_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 76 matching lines @@
 
   // Should be called when the user navigates the main frame.
   void DidNavigateMainFrame(bool is_in_page);
 
   // Handles password forms being parsed.
   void OnPasswordFormsParsed(
       const std::vector<autofill::PasswordForm>& forms);
 
   // Handles password forms being rendered.
   void OnPasswordFormsRendered(
-      const std::vector<autofill::PasswordForm>& visible_forms);
+      const std::vector<autofill::PasswordForm>& visible_forms,
+      bool did_stop_loading);
 
   // Handles a password form being submitted.
   virtual void OnPasswordFormSubmitted(
       const autofill::PasswordForm& password_form);
 
   PasswordManagerClient* client() { return client_; }
 
  private:
   enum ProvisionalSaveFailure {
     SAVING_DISABLED,
@@ skipping 67 matching lines @@
   // want to save passwords but will continue to fill passwords).
   BooleanPrefMember password_manager_enabled_;
 
   // Observers to be notified of LoginModel events.  This is mutable to allow
   // notification in const member functions.
   mutable ObserverList<LoginModelObserver> observers_;
 
   // Callbacks to be notified when a password form has been submitted.
   std::vector<PasswordSubmittedCallback> submission_callbacks_;
 
+  // Records all visible forms in a page. It starts storing when the first

[vabr (Chromium), 2014/06/11 08:22:12]

Please always make sure to give context, especially when using pronouns. (What
is "It"?) Suggested reformulation:

Records all visible forms seen during a page load, in all frames of the page.
When the page stops loading, the password manager checks if one of the recorded
forms matches the login form from the previous page (to see if the login was a
failure), and clears the vector.

+  // visible form is received. When the page stops loading, the password
+  // manager checks the stored visible forms to search for a match for the
+  // login form. It is cleared when a match is found or in the end of search.
+  std::vector<autofill::PasswordForm> all_visible_forms_;
+
   DISALLOW_COPY_AND_ASSIGN(PasswordManager);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_