components/autofill/content/renderer/password_autofill_agent.h - Issue 293093002: Don't show "Save password" prompt for a failed login

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 293093002: Don't show "Save password" prompt for a failed login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/common/autofill_messages.h ('K') | « components/autofill/content/common/autofill_messages.h ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/password_manager/core/browser/password_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index a1ebefc5c394024c87330e5244124be69232a9a2..8c0748ebd87c1f07f444ebc10334d0f4bb8589a3 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -127,6 +127,7 @@ class PasswordAutofillAgent : public content::RenderViewObserver {

virtual void DidStartLoading() OVERRIDE;

virtual void DidFinishDocumentLoad(blink::WebLocalFrame* frame) OVERRIDE;

virtual void DidFinishLoad(blink::WebLocalFrame* frame) OVERRIDE;

+ virtual void DidStopLoading() OVERRIDE;

virtual void FrameDetached(blink::WebFrame* frame) OVERRIDE;

virtual void FrameWillClose(blink::WebFrame* frame) OVERRIDE;

virtual void WillSendSubmitEvent(blink::WebLocalFrame* frame,

@@ -218,6 +219,9 @@ class PasswordAutofillAgent : public content::RenderViewObserver {

// before preview.

int username_selection_start_;

+ // True indicates that all frames have been rendered.

+ bool did_stop_loading_;

base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);