Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 293093002: Don't show "Save password" prompt for a failed login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index f04087983bfc2fa6f8c36c178bc8906400ff0cbd..b9b0016fd7b9ad51e07579b2640894cfe978b3a9 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -94,7 +94,8 @@ class PasswordManager : public LoginModel {
// Handles password forms being rendered.
void OnPasswordFormsRendered(
- const std::vector<autofill::PasswordForm>& visible_forms);
+ const std::vector<autofill::PasswordForm>& visible_forms,
+ bool did_stop_loading);
// Handles a password form being submitted.
virtual void OnPasswordFormSubmitted(
@@ -182,6 +183,9 @@ class PasswordManager : public LoginModel {
// Callbacks to be notified when a password form has been submitted.
std::vector<PasswordSubmittedCallback> submission_callbacks_;
+ // Records all visible forms in a page.
vabr (Chromium) 2014/05/23 12:18:36 Please comment on the time interval for which this
+ std::vector<autofill::PasswordForm> all_visible_forms_;
+
DISALLOW_COPY_AND_ASSIGN(PasswordManager);
};

Powered by Google App Engine
This is Rietveld 408576698