Don't show "Save password" prompt for a failed login

chrome/browser/password_manager/password_manager_browsertest.cc

Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 4793dedd4f9ba260c4ba7a6d425eca316c934868..b89d66437a6978a12e037a53e2ee9ed567cdad0b 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -377,6 +377,26 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
 }
 
 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       NoPromptForFailedLoginWithIrrelevantFramePresent) {
+  NavigateToFile("/password/multi_frames.html");
+
+  // Verify that we do not show password prompt when login failed from one

[vabr (Chromium), 2014/05/23 12:18:36]

Sorry, I have troubles understanding the test from the comment:
1) "failed from one iframe" -- did you mean "failed in one iframe", or something
else?
2) Could you also explain both the navigation which happens in the iframe, and
in the main frame, and how is that supposed to be interpreted by the password
manager?

+  // iframe with a different iframe being present in the same page.
+  NavigationObserver observer(WebContents());
+  std::string fill_and_submit =
+        "var first_frame = document.getElementById('first_frame');"
+        "var frame_doc = first_frame.contentDocument;"
+        "frame_doc.getElementById('username_failed').value = 'temp';"
+        "frame_doc.getElementById('password_failed').value = 'random';"
+        "frame_doc.getElementById('submit_failed').click();";
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(),
+                                     "window.location.href = 'failed.html';"));

[vabr (Chromium), 2014/05/23 12:18:36]

Why do you navigate the main frame to failed.html -- should that work with any
other navigation as well?

I just ran the test with the rest of your patch disabled (always sending true
with AutofillHostMsg_PasswordFormsRendered from the PasswordAutofillAgent, and
the test passed as well.

+  observer.Wait();
+  EXPECT_FALSE(observer.infobar_shown());
+}
+
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
                        PromptForXHRSubmit) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).