Don't show "Save password" prompt for a failed login

chrome/browser/password_manager/password_manager_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/metrics/statistics_recorder.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 359 matching lines @@
       "frame_doc.getElementById('password_field').value = 'random';"
       "frame_doc.getElementById('input_submit_button').click();";
 
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), navigate_frame));
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
   observer.Wait();
   EXPECT_TRUE(observer.infobar_shown());
 }
 
 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       NoPromptForFailedLoginWithIrrelevantFramePresent) {
+  NavigateToFile("/password/multi_frames.html");
+
+  // Verify that we do not show password prompt when login failed from one

[vabr (Chromium), 2014/05/23 12:18:36]

Sorry, I have troubles understanding the test from the comment:
1) "failed from one iframe" -- did you mean "failed in one iframe", or something
else?
2) Could you also explain both the navigation which happens in the iframe, and
in the main frame, and how is that supposed to be interpreted by the password
manager?

+  // iframe with a different iframe being present in the same page.
+  NavigationObserver observer(WebContents());
+  std::string fill_and_submit =
+        "var first_frame = document.getElementById('first_frame');"
+        "var frame_doc = first_frame.contentDocument;"
+        "frame_doc.getElementById('username_failed').value = 'temp';"
+        "frame_doc.getElementById('password_failed').value = 'random';"
+        "frame_doc.getElementById('submit_failed').click();";
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(),
+                                     "window.location.href = 'failed.html';"));

[vabr (Chromium), 2014/05/23 12:18:36]

Why do you navigate the main frame to failed.html -- should that work with any
other navigation as well?

I just ran the test with the rest of your patch disabled (always sending true
with AutofillHostMsg_PasswordFormsRendered from the PasswordAutofillAgent, and
the test passed as well.

+  observer.Wait();
+  EXPECT_FALSE(observer.infobar_shown());
+}
+
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
                        PromptForXHRSubmit) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
   NavigateToFile("/password/password_xhr_submit.html");
 
   // Verify that we show the save password prompt if a form returns false
   // in its onsubmit handler but instead logs in/navigates via XHR.
@@ skipping 357 matching lines @@
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill));
 
   NavigationObserver observer(WebContents());
   GURL url = embedded_test_server()->GetURL("/password/password_form.html");
   chrome::NavigateParams params(browser(), url,
                                 content::PAGE_TRANSITION_RELOAD);
   ui_test_utils::NavigateToURL(&params);
   observer.Wait();
   EXPECT_FALSE(observer.infobar_shown());
 }