Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 293093002: Don't show "Save password" prompt for a failed login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index b8efde51cec758f9e03b6c2b60f7ce28bf85aa86..45a7f93fa47ac6c34420636852c080608e5f69fc 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -95,7 +95,8 @@ class PasswordManager : public LoginModel {
// Handles password forms being rendered.
void OnPasswordFormsRendered(
- const std::vector<autofill::PasswordForm>& visible_forms);
+ const std::vector<autofill::PasswordForm>& visible_forms,
+ bool did_stop_loading);
// Handles a password form being submitted.
virtual void OnPasswordFormSubmitted(
@@ -188,6 +189,12 @@ class PasswordManager : public LoginModel {
// Callbacks to be notified when a password form has been submitted.
std::vector<PasswordSubmittedCallback> submission_callbacks_;
+ // Records all visible forms seen during a page load, in all frames of the
+ // page. When the page stops loading, the password manager checks if one of
+ // the recorded forms matches the login form from the previous page
+ // (to see if the login was a failure), and clears the vector.
+ std::vector<autofill::PasswordForm> all_visible_forms_;
+
DISALLOW_COPY_AND_ASSIGN(PasswordManager);
};

Powered by Google App Engine
This is Rietveld 408576698