Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 293093002: Don't show "Save password" prompt for a failed login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index f989b981d2f1649d5a90f3ce6885c5888b478578..91a28136654a6048e1ee901d05549da18823d1c4 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -232,6 +232,7 @@ PasswordAutofillAgent::PasswordAutofillAgent(content::RenderView* render_view)
was_username_autofilled_(false),
was_password_autofilled_(false),
username_selection_start_(0),
+ did_stop_loading_(false),
weak_ptr_factory_(this) {
Send(new AutofillHostMsg_PasswordAutofillAgentConstructed(routing_id()));
}
@@ -535,7 +536,8 @@ void PasswordAutofillAgent::SendPasswordForms(blink::WebFrame* frame,
if (only_visible) {
Send(new AutofillHostMsg_PasswordFormsRendered(routing_id(),
- password_forms));
+ password_forms,
+ did_stop_loading_));
} else {
Send(new AutofillHostMsg_PasswordFormsParsed(routing_id(), password_forms));
}
@@ -552,6 +554,7 @@ bool PasswordAutofillAgent::OnMessageReceived(const IPC::Message& message) {
}
void PasswordAutofillAgent::DidStartLoading() {
+ did_stop_loading_ = false;
if (usernames_usage_ != NOTHING_TO_AUTOFILL) {
UMA_HISTOGRAM_ENUMERATION("PasswordManager.OtherPossibleUsernamesUsage",
usernames_usage_,
@@ -575,6 +578,10 @@ void PasswordAutofillAgent::DidFinishLoad(blink::WebLocalFrame* frame) {
SendPasswordForms(frame, true);
}
+void PasswordAutofillAgent::DidStopLoading() {
+ did_stop_loading_ = true;
+}
+
void PasswordAutofillAgent::FrameDetached(blink::WebFrame* frame) {
FrameClosing(frame);
}

Powered by Google App Engine
This is Rietveld 408576698