Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 2930873002: Add missing #include <cerrno> in socket_options.cc (Closed)

Created:
3 years, 6 months ago by hugoh_UTC2
Modified:
3 years, 6 months ago
Reviewers:
tfarina, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing #include <cerrno> in socket_options.cc One of our toolchains does not expose |errno| in the global namespace. BUG=none Review-Url: https://codereview.chromium.org/2930873002 Cr-Commit-Position: refs/heads/master@{#479366} Committed: https://chromium.googlesource.com/chromium/src/+/c825632ff5cbb347dbc6aead3c5e305eb74d3e4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/socket/socket_options.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hugoh_UTC2
tfarina@ PTAL
3 years, 6 months ago (2017-06-08 12:38:32 UTC) #2
hugoh_UTC2
eroman@ Could you approve at this trivial change?
3 years, 6 months ago (2017-06-12 09:52:10 UTC) #4
eroman
lgtm
3 years, 6 months ago (2017-06-12 18:01:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930873002/1
3 years, 6 months ago (2017-06-14 11:37:27 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 13:19:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c825632ff5cbb347dbc6aead3c5e...

Powered by Google App Engine
This is Rietveld 408576698