Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2730)

Unified Diff: chrome/browser/permissions/permission_prompt_android.cc

Issue 2930843002: Allow modal mic+camera permission prompts in PRM codepath (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_dialog_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_prompt_android.cc
diff --git a/chrome/browser/permissions/permission_prompt_android.cc b/chrome/browser/permissions/permission_prompt_android.cc
index 7e47372f443f4dc6e828f12d23e80b83059a97f4..616602293ffb1f0718022d32db914915a8e48277 100644
--- a/chrome/browser/permissions/permission_prompt_android.cc
+++ b/chrome/browser/permissions/permission_prompt_android.cc
@@ -29,15 +29,11 @@ void PermissionPromptAndroid::SetDelegate(Delegate* delegate) {
}
void PermissionPromptAndroid::Show() {
- // Grouped permission requests are not yet supported in dialogs.
- // TODO(timloh): Handle grouped media permissions (camera + microphone).
- if (delegate_->Requests().size() == 1) {
- bool has_gesture = delegate_->Requests()[0]->GetGestureType() ==
- PermissionRequestGestureType::GESTURE;
- if (PermissionDialogDelegate::ShouldShowDialog(has_gesture)) {
- PermissionDialogDelegate::Create(web_contents_, this);
- return;
- }
+ bool has_gesture = delegate_->Requests()[0]->GetGestureType() ==
+ PermissionRequestGestureType::GESTURE;
raymes 2017/06/13 04:27:30 Should this check all the requests? It looks a bit
Timothy Loh 2017/06/14 04:56:43 Done.
+ if (PermissionDialogDelegate::ShouldShowDialog(has_gesture)) {
+ PermissionDialogDelegate::Create(web_contents_, this);
+ return;
}
InfoBarService* infobar_service =
« no previous file with comments | « chrome/browser/permissions/permission_dialog_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698