Allow modal mic+camera permission prompts in PRM codepath

Allow modal mic+camera permission prompts in PRM codepath

This patch allows modal permission prompts for grouped mic+camera when
the PermissionRequestManager is enabled and used for media requests.

BUG=606138
Review-Url: https://codereview.chromium.org/2930843002
Cr-Commit-Position: refs/heads/master@{#479591}
Committed: https://chromium.googlesource.com/chromium/src/+/0a055d2dff1aeb841d126dc59ba529c55de79dd8

[Timothy Loh, 2017-06-08 07:55:16]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 07:55:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 09:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 09:33:31]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2017-06-13 03:32:33]

timloh@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2017-06-13 04:27:30]

https://codereview.chromium.org/2930843002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_prompt_android.cc (right):

https://codereview.chromium.org/2930843002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.cc:33:
PermissionRequestGestureType::GESTURE;
Should this check all the requests? It looks a bit funny.

[Timothy Loh, 2017-06-14 04:55:15]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 04:55:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-06-14 04:56:43]

https://codereview.chromium.org/2930843002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_prompt_android.cc (right):

https://codereview.chromium.org/2930843002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.cc:33:
PermissionRequestGestureType::GESTURE;
On 2017/06/13 04:27:30, raymes wrote:
> Should this check all the requests? It looks a bit funny.

Done.

[commit-bot: I haz the power, 2017-06-14 06:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 06:42:12]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-06-14 22:45:29]

lgtm

[Timothy Loh, 2017-06-15 03:13:36]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-06-15 03:13:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 03:17:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497496416314610,
"parent_rev": "ed032341d39d2e67a9b341f1142fdf49684c144c", "commit_rev":
"0a055d2dff1aeb841d126dc59ba529c55de79dd8"}

[commit-bot: I haz the power, 2017-06-15 03:17:25]

Description was changed from

==========
Allow modal mic+camera permission prompts in PRM codepath

This patch allows modal permission prompts for grouped mic+camera when
the PermissionRequestManager is enabled and used for media requests.

BUG=606138
==========

to

==========
Allow modal mic+camera permission prompts in PRM codepath

This patch allows modal permission prompts for grouped mic+camera when
the PermissionRequestManager is enabled and used for media requests.

BUG=606138

Review-Url: https://codereview.chromium.org/2930843002
Cr-Commit-Position: refs/heads/master@{#479591}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a055d2dff1aeb841d126dc59ba5...
==========

[commit-bot: I haz the power, 2017-06-15 03:17:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a055d2dff1aeb841d126dc59ba5...