[wasm] Wasm Memory/Table relocations should not be GC'ed enums

[wasm] Wasm Memory/Table relocations should not be GC'ed enums

Review-Url: https://codereview.chromium.org/2930833002
Cr-Commit-Position: refs/heads/master@{#45780}
Committed: https://chromium.googlesource.com/v8/v8/+/b3802dbbd833a94bbc1906b152c3fd7929e6e302

[gdeepti, 2017-06-08 05:26:39]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 05:26:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 05:56:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 05:56:14]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-06-08 05:59:07]

Description was changed from

==========
Test reloc information to not be GC'd

BUG=
==========

to

==========
[wasm] Wasm Memory/Table relocations should not be GC'ed enums
==========

[gdeepti, 2017-06-08 05:59:07]

gdeepti@chromium.org changed reviewers:
+ mtrofin@chromium.org

[gdeepti, 2017-06-08 06:01:13]

The error with Wasm reloc info types needing to be GC'ed does not seem to exist
anymore, sending this out to fix it.

[Mircea Trofin, 2017-06-08 06:41:48]

lgtm, just a code comment nit.

https://codereview.chromium.org/2930833002/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/2930833002/diff/1/src/assembler.h#newcode359
src/assembler.h:359: // Everything after runtime_entry (inclusive) is not GC'ed.
Is this comment pertinent anymore? shouldn't it be moved to after
embedded_object?

[gdeepti, 2017-06-08 07:18:42]

https://codereview.chromium.org/2930833002/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/2930833002/diff/1/src/assembler.h#newcode359
src/assembler.h:359: // Everything after runtime_entry (inclusive) is not GC'ed.
On 2017/06/08 06:41:48, Mircea Trofin wrote:
> Is this comment pertinent anymore? shouldn't it be moved to after
> embedded_object?

Done.

[gdeepti, 2017-06-08 07:20:40]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2017-06-08 07:20:41]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2930833002/#ps20001
(title: "Mircea's review")

[commit-bot: I haz the power, 2017-06-08 07:20:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 07:49:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496906440991330,
"parent_rev": "e65e2f870e34deadcc3607dffb38ac8304fae9e7", "commit_rev":
"b3802dbbd833a94bbc1906b152c3fd7929e6e302"}

[commit-bot: I haz the power, 2017-06-08 07:49:56]

Description was changed from

==========
[wasm] Wasm Memory/Table relocations should not be GC'ed enums
==========

to

==========
[wasm] Wasm Memory/Table relocations should not be GC'ed enums

Review-Url: https://codereview.chromium.org/2930833002
Cr-Commit-Position: refs/heads/master@{#45780}
Committed:
https://chromium.googlesource.com/v8/v8/+/b3802dbbd833a94bbc1906b152c3fd7929e...
==========

[commit-bot: I haz the power, 2017-06-08 07:49:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b3802dbbd833a94bbc1906b152c3fd7929e...