Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2930813003: Changed the highlight color to be a less abrasive yellow as per (Closed)

Created:
3 years, 6 months ago by cwpayton
Modified:
3 years, 6 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Changed the highlight color to be a less abrasive yellow as per M-A Ruel's suggestion on cl 2921983002 BUG=727947 Review-Url: https://codereview.chromium.org/2930813003 Committed: https://github.com/luci/luci-py/commit/d0e96b62aa25eae0a3660f0390ed6baef8abffda

Patch Set 1 #

Patch Set 2 : re-vulcanize and re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/build/js/js.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
cwpayton
Marc-Antoine noted that the highlight color was too loud for the viewer, and suggested a ...
3 years, 6 months ago (2017-06-08 17:03:19 UTC) #2
Ryan Tseng
Can you attach a screenshot (for this, and all other UI related CLs), re-vulcanize the ...
3 years, 6 months ago (2017-06-08 17:47:15 UTC) #3
cwpayton
PTAL
3 years, 6 months ago (2017-06-08 18:10:17 UTC) #5
Ryan Tseng
Put the screenshot as a message reply, not in the description. Because this is going ...
3 years, 6 months ago (2017-06-08 18:14:09 UTC) #6
cwpayton
On 2017/06/08 18:14:09, Ryan Tseng wrote: > Put the screenshot as a message reply, not ...
3 years, 6 months ago (2017-06-08 18:18:07 UTC) #8
Sergey Berezin
+maruel for the final verdict (since he asked for it). LGTM on my side - ...
3 years, 6 months ago (2017-06-08 18:37:45 UTC) #10
M-A Ruel
On 2017/06/08 18:37:45, Sergey Berezin wrote: > +maruel for the final verdict (since he asked ...
3 years, 6 months ago (2017-06-08 18:43:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930813003/20001
3 years, 6 months ago (2017-06-08 18:43:44 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 18:47:01 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/d0e96b62aa25eae0a3660f0390ed6baef8abffda

Powered by Google App Engine
This is Rietveld 408576698