Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2930803002: Remove flag --disable-views-rect-based-targeting (Closed)

Created:
3 years, 6 months ago by tdanderson
Modified:
3 years, 6 months ago
Reviewers:
sadrul, Mark P
CC:
chromium-reviews, tfarina, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flag --disable-views-rect-based-targeting Rect-based targeting in views (the use of a heuristic to determine the most probable target of a gesture event) has been on by default since M-33. This CL removes the flag that allows the feature to be disabled. BUG=347147 TEST=none Review-Url: https://codereview.chromium.org/2930803002 Cr-Commit-Position: refs/heads/master@{#478401} Committed: https://chromium.googlesource.com/chromium/src/+/33cf86dbf7551bbbcb1dc6cc4ef1dea9b84e90d9

Patch Set 1 #

Patch Set 2 : restore enum entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -50 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/view_targeter_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M ui/views/views_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/views_switches.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M ui/views/widget/root_view_targeter.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
tdanderson
Sadrul, can you please take a look?
3 years, 6 months ago (2017-06-07 21:08:29 UTC) #3
sadrul
lgtm
3 years, 6 months ago (2017-06-08 20:33:55 UTC) #7
tdanderson
mpearson@, can you please take a look at tools/ ?
3 years, 6 months ago (2017-06-09 17:50:50 UTC) #9
Mark P
On 2017/06/09 17:50:50, tdanderson wrote: > mpearson@, can you please take a look at tools/ ...
3 years, 6 months ago (2017-06-09 17:52:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930803002/20001
3 years, 6 months ago (2017-06-09 19:26:10 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 20:35:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33cf86dbf7551bbbcb1dc6cc4ef1...

Powered by Google App Engine
This is Rietveld 408576698