Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/closure_compiler/compiler_test.py

Issue 2930773003: Closure compilation: Modify compile_js2.py to not swallow errors. (Closed)
Patch Set: More changes. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/closure_compiler/compile2.py ('K') | « third_party/closure_compiler/compile2.py ('k') | third_party/closure_compiler/js_minify.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/closure_compiler/compiler_test.py
diff --git a/third_party/closure_compiler/compiler_test.py b/third_party/closure_compiler/compiler_test.py
index 847826071d6aa9702074ba8e7feb5649dc94c915..6dcc1df71b8e7046bc9b16462a8e6dd417db0dab 100755
--- a/third_party/closure_compiler/compiler_test.py
+++ b/third_party/closure_compiler/compiler_test.py
@@ -52,9 +52,10 @@ class CompilerTest(unittest.TestCase):
args.remove("checks_only")
sources = [file_path, _CHROME_SEND_EXTERNS]
- found_errors, stderr = self._checker.check(sources,
- out_file=out_file,
- closure_args=args)
+ return_code, found_errors, stderr = self._checker.check(
+ sources,
+ out_file=out_file,
+ closure_args=args)
return found_errors, stderr, out_file, out_map
def _runCheckerTestExpectError(self, source_code, expected_error,
« third_party/closure_compiler/compile2.py ('K') | « third_party/closure_compiler/compile2.py ('k') | third_party/closure_compiler/js_minify.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698