third_party/closure_compiler/js_minify.py - Issue 2930773003: Closure compilation: Modify compile_js2.py to not swallow errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/js_minify.py

Issue 2930773003: Closure compilation: Modify compile_js2.py to not swallow errors. (Closed)

Patch Set: More changes. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/closure_compiler/js_minify.py

diff --git a/third_party/closure_compiler/js_minify.py b/third_party/closure_compiler/js_minify.py

index 52cc876aff46737bfd7ed986f46c1aa8d79fc564..7980d61673204b5d11e3433eae1ec1bea858c986 100755

--- a/third_party/closure_compiler/js_minify.py

+++ b/third_party/closure_compiler/js_minify.py

@@ -28,7 +28,7 @@ def Minify(source):

t1.write(source)

t1.seek(0)

checker = Checker()

- (compile_error, compile_stderr) = checker.check(

+ (_, compile_error, compile_stderr) = checker.check(

[t1.name],

out_file=t2.name,

closure_args=args.closure_args)