[Snowflake] Unify toolbar text styles

chrome/android/java/res/values/dimens.xml

Index: chrome/android/java/res/values/dimens.xml
diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml
index 0e0e4bcdbce26f39d8083fdf3ec8dc6fc4a42bdb..535091e88b01f830d74759a11f88262d9676770a 100644
--- a/chrome/android/java/res/values/dimens.xml
+++ b/chrome/android/java/res/values/dimens.xml
@@ -274,8 +274,8 @@
     <dimen name="omnibox_suggestion_height">60dp</dimen>
     <dimen name="omnibox_suggestion_answer_height">72dp</dimen>
     <dimen name="omnibox_suggestion_definition_height">95dp</dimen>
-    <dimen name="omnibox_suggestion_list_padding_top">0dp</dimen>
-    <dimen name="omnibox_suggestion_list_padding_bottom">0dp</dimen>
+    <dimen name="omnibox_suggestion_list_padding_top">8dp</dimen>
+    <dimen name="omnibox_suggestion_list_padding_bottom">8dp</dimen>

[Theresa, 2017/06/08 16:12:24]

These also exist in values-sw600dp/dimens.xml; I having trouble tracing the
origins of why we use 0dp here but 8dp in sw600dp for tablets due to upstreaming
a couple of years ago.

+tedchoc@ - do you recall (or know someone who may recall) why the suggestions
padding is different for phones and tablets?

[Ted C, 2017/06/08 16:37:39]

I suspect that dates back to the original material design change in chrome.  I
would guess that the tablet is a dropdown and the phone is a full sheet so maybe
this padding was just unnecessary?  We might end up getting a scrollbar
unnecessarily if it barely just fit where the padding overflows past the
keyboard.

If we have screenshots with 1 suggestion and a full set of suggestions, and ux
signs off on it, then they've updated their specs.

Legacy code review.
https://chrome-internal-review.googlesource.com/c/172055/

     <dimen name="omnibox_suggestion_first_line_text_size">16sp</dimen>
     <dimen name="omnibox_suggestion_second_line_text_size">14sp</dimen>
     <dimen name="omnibox_suggestion_answer_line2_vertical_spacing">3dp</dimen>